Skip to content

Added SearchTemplate support for reactive client #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2021
Merged

Added SearchTemplate support for reactive client #1726

merged 4 commits into from
Mar 16, 2021

Conversation

bilak
Copy link
Contributor

@bilak bilak commented Mar 14, 2021

Closes #1725

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 14, 2021
sothawo
sothawo requested changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this PR, looks really great. Some minor comments I added to the files.

bilak and others added 3 commits March 16, 2021 15:55
@bilak @sothawo
Update src/test/java/org/springframework/data/elasticsearch/client/re…
6d7055f 
…active/ReactiveElasticsearchClientIntegrationTests.java

Co-authored-by: Peter-Josef Meisch <[email protected]>
@bilak @sothawo
Update src/test/java/org/springframework/data/elasticsearch/client/re…
0a033a2 
…active/ReactiveElasticsearchClientIntegrationTests.java

Co-authored-by: Peter-Josef Meisch <[email protected]>
@bilak
Added method with SearchTemplateRequest consumer
b70971c
@bilak bilak requested a review from sothawo March 16, 2021 16:59
@sothawo sothawo merged commit 005d6a4 into spring-projects:master Mar 16, 2021
@sothawo
Copy link
Collaborator

sothawo commented Mar 16, 2021

Thank you again for this PR, it has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sothawo sothawo sothawo approved these changes

Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for SearchTemplate for reactive client
3 participants
@bilak @sothawo @spring-projects-issues